Request a Demo
Home   >   mailing lists

Re: [PATCH] Add tests for src/backend/nodes/extensible.c - Mailing list pgsql-hackers

From Rafia Sabih
Subject Re: [PATCH] Add tests for src/backend/nodes/extensible.c
Date
Msg-id CA+FpmFfUMovM7XPrAh69CsBxm6=TdTjR_NKx_TUU+ys0cCn18w@mail.gmail.com
Whole thread
In response to [PATCH] Add tests for src/backend/nodes/extensible.c  (Aleksander Alekseev <aleksander@tigerdata.com>)
List pgsql-hackers
Tree view


On Thu, 30 Jul 2026 at 18:21, Aleksander Alekseev <aleksander@tigerdata.com> wrote:
Hi Rafia,

> I looked into this patch and have a few comments.
> Firstly, in test_create_custom_scan_state() why hard coding  css.slotOps = &TTSOpsBufferHeapTuple and not using the table_slot_callbacks() for the purpose and getting the real AM.
> Next, in test_plan_custom_path, the last two arguments are never used.
> There are no tests for nodeCopy, nodeEqual, nodeOut, and nodeRead routines.

Many thanks for the feedback! Here is the corrected patch.

Thanks. There is a typo in the current patch --... the CustomScanStateand and is expected
Other than that it looks good to me.


--
Regards,
Rafia Sabih
CYBERTEC PostgreSQL International GmbH

pgsql-hackers by date:

Previous
From: shveta malik
Date:
Subject: Re: [PATCH] Release replication slot on error in SQL-callable slot functions
Next
From: Chao Li
Date:
Subject: Re: Reduce memory overheads for storing a Memoize tuple