Re: tablecmds: fix bug where index rebuild loses replica identity on partitions - Mailing list pgsql-hackers

From Álvaro Rodríguez
Subject Re: tablecmds: fix bug where index rebuild loses replica identity on partitions
Date
Msg-id CA+C_kKWVb5PrrGJM5Bd4rPsf-V=h20xoeCHMtPy3WCYy4=YwUQ@mail.gmail.com
Whole thread
In response to tablecmds: fix bug where index rebuild loses replica identity on partitions  (Chao Li <li.evan.chao@gmail.com>)
List pgsql-hackers
Hi all,

I have been working on another patch [0] and was pointed to this
thread. My changes are focused on avoiding preventable rebuilds of the
leaf indexes on partitioned tables, when we do ALTER TABLE ALTER
COLUMN TYPE. I change the order in which indexes are processed and do
some other minor changes to ensure that they are correctly remembered
on rebuild.

I believe commit 0003 here addresses a subset of the issues that my
patch fixes. To validate, I have combined 0001 + 0002 + my patch +
0003's tests and the tests seem to be passing (the only change in test
output is the at_partitioned test, where I get the storage changes
that my patch is fixing). Commits 0001 and 0002 are not addressed by
my patch at all, as far as I can tell. I wonder if it's worth joining
efforts!

Best,
Álvaro

[0]
https://www.postgresql.org/message-id/flat/CA%2BC_kKX9Qk0JQZ%2BbjyHWNiCBLYN4kyCRdJoJ%2Bgtr1K2%2BXjo55g%40mail.gmail.com



pgsql-hackers by date:

Previous
From: Zhijie Hou
Date:
Subject: Re: Parallel Apply
Next
From: Matthias van de Meent
Date:
Subject: Re: Exploring pass-by-value for small Bitmapset sets