Postgres Pro
Downloads
Home   >   mailing lists

Missing pfree in logical_heap_rewrite_flush_mappings() - Mailing list pgsql-hackers

From Ants Aasma
Subject Missing pfree in logical_heap_rewrite_flush_mappings()
Date
Msg-id CA+CSw_sBGzgeG+gbwpTopAQdiuQuhHgewWjZQCR0Rb435Ps4OQ@mail.gmail.com
Whole thread Raw
Responses Re: Missing pfree in logical_heap_rewrite_flush_mappings()  (Stephen Frost <sfrost@snowman.net>)
Re: Missing pfree in logical_heap_rewrite_flush_mappings()  (Bruce Momjian <bruce@momjian.us>)
List pgsql-hackers
Tree view 
It seems to me that when flushing logical mappings to disk, each
mapping file leaks the buffer used to pass the mappings to XLogInsert.
Also, it seems consistent to allocate that buffer in the RewriteState
memory context. Patch attached.

Regards,
Ants Aasma
--
Cybertec Schönig & Schönig GmbH
Gröhrmühlgasse 26
A-2700 Wiener Neustadt
Web: http://www.postgresql-support.de
Attachment

pgsql-hackers by date:

Previous
From: Heikki Linnakangas
Date:
Subject: Re: Only first XLogRecData is visible to rm_desc with WAL_DEBUG
Next
From: Andrew Dunstan
Date:
Subject: Re: small regression adjustment