Reject invalid databases in pg_get_database_ddl() - Mailing list pgsql-hackers

From Lakshmi N
Subject Reject invalid databases in pg_get_database_ddl()
Date
Msg-id CA+3i_M8m1k2gFch+tU0JmAQh9FRV+pFrfTXDrJo+BqmwsTmOhg@mail.gmail.com
Whole thread
Responses Re: Reject invalid databases in pg_get_database_ddl()
List pgsql-hackers
Hi,

pg_get_database_ddl() is not checking for databases in an invalid state
before producing ddl statements. This caused the function to emit
CONNECTION_LIMIT = -2, which is invalid SQL that Postgres rejects.
A database row can be in this inconsistent state longer, for example
server crashed during a drop database.

Attached patch to fix this issue by doing a database_is_invalid_form()
check early in pg_get_database_ddl_internal().

Regards,
Lakshmi
Attachment

pgsql-hackers by date:

Previous
From: Peter Eisentraut
Date:
Subject: Re: Make copyObject work in C++
Next
From: Jakub Wartak
Date:
Subject: Re: Add errdetail() with PID and UID about source of termination signal