Re: Show VIRTUAL keyword for virtual generated columns in pg_dump and psql - Mailing list pgsql-hackers

From Lakshmi N
Subject Re: Show VIRTUAL keyword for virtual generated columns in pg_dump and psql
Date
Msg-id CA+3i_M8j0WqTF3_BEWkAdJk=5DjaQQhefP-yVZ1O15F_qT52kg@mail.gmail.com
Whole thread
In response to Re: Show VIRTUAL keyword for virtual generated columns in pg_dump and psql  ("David G. Johnston" <david.g.johnston@gmail.com>)
List pgsql-hackers
Hi,

On Mon, Apr 13, 2026 at 5:27 AM David G. Johnston <david.g.johnston@gmail.com> wrote:
On Monday, April 13, 2026, Lakshmi N <lakshmin.jhs@gmail.com> wrote:
pg_dump and psql's \d currently display stored and virtual generated
columns asymmetrically:


    s_total integer GENERATED ALWAYS AS ((a + b)) STORED
    v_total integer GENERATED ALWAYS AS ((a + b))

Since VIRTUAL is default most likely this was omitted but with this
puts the burden on the reader to identify whether it is STORED or 
VIRTUAL since both kinds coexist in v19.

The output follows existing conventions of not printing extraneous text.  Additionally, storage itself is non-standard so the absence of a modifier is producing standard-compliant output.  I would -1 changing pg_dump on this basis.  I’d be inclined to go with the symmetry/readability argument for psql \d though.

Thank you for the feedback! Updated the patch for psql \d only. 

 Regards,
Lakshmi
Attachment

pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: Why is_admin_of_role() use ROLERECURSE_MEMBERS rather thanROLERECURSE_PRIVS?
Next
From: "Matheus Alcantara"
Date:
Subject: Re: docs: Include database collation check on SQL from alter_collation.sgml