Re: abi-compliance-check failure due to recent changes to pg_{clear,restore}_{attribute,relation}_stats() - Mailing list pgsql-hackers

From David E. Wheeler
Subject Re: abi-compliance-check failure due to recent changes to pg_{clear,restore}_{attribute,relation}_stats()
Date
Msg-id C59DBE6C-5067-4DCE-BD57-9C7DA7CD892B@justatheory.com
Whole thread Raw
In response to Re: abi-compliance-check failure due to recent changes to pg_{clear,restore}_{attribute,relation}_stats()  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On Oct 17, 2025, at 19:07, Tom Lane <tgl@sss.pgh.pa.us> wrote:

> That seems overcomplicated: how does the buildfarm know
> what's a maintenance branch?  I think the rule should be
> just "run ABI checks if the control file exists, else not".
>
> As an example of why that's better, what if we did decide
> we wanted ABI checks on master?

It’s part of the design of the build farm. The setup() function[0] checks various things to see if it should be run,
e.g.,

```perl
    if ($^O ne 'linux')
    {
        emit("Only Linux is supported for ABICompCheck Module, skipping.");
        return;
    }

    # Only proceed if this is a stable branch with git SCM, not using msvc
    if ($conf->{scm} ne 'git')
    {
        emit("Only git SCM is supported for ABICompCheck Module, skipping.");
        return;
    }
    if ($branch !~ /_STABLE$/)
    {
        emit("Skipping ABI check; '$branch' is not a stable branch.");
        return;
    }
```

So as long as the branch naming remains consistent it should work.

D


[0]
https://github.com/PGBuildFarm/client-code/pull/38/files#diff-207ca93813cc123f656dbb12b7723d305e9ade5e03d7b1cdb406180e4eaab9a2R194


Attachment

pgsql-hackers by date:

Previous
From: Jim Jones
Date:
Subject: Re: [PATCH] Add pg_get_trigger_ddl() to retrieve the CREATE TRIGGER statement
Next
From: "David E. Wheeler"
Date:
Subject: Re: abi-compliance-check failure due to recent changes to pg_{clear,restore}_{attribute,relation}_stats()