Re: PATCH: CITEXT 2.0 v3 - Mailing list pgsql-hackers

From David E. Wheeler
Subject Re: PATCH: CITEXT 2.0 v3
Date
Msg-id C4D10B4C-DCF7-4377-8E82-A1FC95B75BC9@kineticode.com
Whole thread Raw
In response to Re: PATCH: CITEXT 2.0 v3  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On Jul 11, 2008, at 16:45, Tom Lane wrote:

> Not sure about a memory leak, but this code is clearly wrong if
> str_tolower results in a change of physical string length (clearly
> possible in Turkish, for instance, and probably in some other
> locales too).  You need to do strlen's on the lowercased strings.

Ah, great point. Thanks.

Anyone else got an idea on the memory leak?

Best,

David


pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: PATCH: CITEXT 2.0 v3
Next
From: Gregory Stark
Date:
Subject: Re: posix advises ...