Re: Remove redundant MultiXactIdIsRunning() check in HeapTupleSatisfiesUpdate() - Mailing list pgsql-hackers

From Zhao Song
Subject Re: Remove redundant MultiXactIdIsRunning() check in HeapTupleSatisfiesUpdate()
Date
Msg-id C2096460-850F-4200-BA1F-9202F73C01FF@icloud.com
Whole thread
In response to Re: Remove redundant MultiXactIdIsRunning() check in HeapTupleSatisfiesUpdate()  (Chao Li <li.evan.chao@gmail.com>)
List pgsql-hackers
> I think your analysis is correct. The "if (TransactionIdDidCommit(xmax))" branch cannot change the result of
MultiXactIdIsRunning(),so the later check is redundant. 
>
> But I think we should delete the “By here …” comment and retain the “There's no member …” comment because it explains
whymarking xmax invalid is safe. 

Thanks for the review.
Agreed, the "There's no member ..." comment now answers the question the old one asked. v2 attached.

Regards,
Zhao Song

Attachment

pgsql-hackers by date:

Previous
From: Michael Paquier
Date:
Subject: Re: Memory leak in statext_ndistinct_build() during ANALYZE
Next
From: Michael Paquier
Date:
Subject: Re: Reapply graceful socket shutdown on Windows (revert 29992a6a509)