RE: [Proposal] Level4 Warnings show many shadow vars - Mailing list pgsql-hackers

From Ranier Vilela
Subject RE: [Proposal] Level4 Warnings show many shadow vars
Date
Msg-id BN8PR18MB2916D7FCFBC10BA0494C0F0EE35F0@BN8PR18MB2916.namprd18.prod.outlook.com
Whole thread Raw
In response to Re: [Proposal] Level4 Warnings show many shadow vars  (Robert Haas <robertmhaas@gmail.com>)
Responses Re: [Proposal] Level4 Warnings show many shadow vars  (Mark Dilger <hornschnorter@gmail.com>)
List pgsql-hackers
Robert Haas wrote:
>Maybe you want to post a few examples. It's hard to discuss in the abstract.
I am working on the patch.
I think this is a great example.
I do not know if it is better to rename the local parameter, or if it should be renamed the global variable.

line: 68
var char **synchronous_commit
backend/commands/subscriptioncmds.c

global var declared here:
/include/access/xact.h(82)

One question, is it better to submit the patch on this topic, or create a new one?

regards,
Ranier Vilela


pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: 'Invalid lp' during heap_xlog_delete
Next
From: Tom Lane
Date:
Subject: Re: ssl passphrase callback