Re: patch: tsearch - some memory diet - Mailing list pgsql-hackers

From Robert Haas
Subject Re: patch: tsearch - some memory diet
Date
Msg-id BFC2392A-9049-4019-BCCC-C5760FA3BF2D@gmail.com
Whole thread Raw
In response to Re: patch: tsearch - some memory diet  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: patch: tsearch - some memory diet
List pgsql-hackers
On Oct 3, 2010, at 7:02 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> It's not at all apparent that the code is even
> safe as-is, because it's depending on the unstated assumption that that
> static variable will get reset once per dictionary.  The documentation
> is horrible: it doesn't really explain what the patch is doing, and what
> it does say is wrong.

Yep. We certainly would need to convince ourselves that this is correct before applying it, and that is all kinds of
non-obvious.

...Robert

pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: INSERT ... VALUES... with ORDER BY / LIMIT
Next
From: Steve Singer
Date:
Subject: Re: Review: Fix snapshot taking inconsistencies