Re: [PATCH] fix DROP OPERATOR to reset links to itself on commutator and negator - Mailing list pgsql-hackers

From Roma Sokolov
Subject Re: [PATCH] fix DROP OPERATOR to reset links to itself on commutator and negator
Date
Msg-id BF79B347-E974-4FF8-843D-9FBD68596F35@gmail.com
Whole thread Raw
In response to Re: [PATCH] fix DROP OPERATOR to reset links to itself on commutator and negator  (Euler Taveira <euler@timbira.com.br>)
Responses Re: [PATCH] fix DROP OPERATOR to reset links to itself on commutator and negator  (David Steele <david@pgmasters.net>)
Re: [PATCH] fix DROP OPERATOR to reset links to itself on commutator and negator  (Tomas Vondra <tomas.vondra@2ndquadrant.com>)
List pgsql-hackers
> On 27 Feb 2016, at 03:46, Euler Taveira <euler@timbira.com.br> wrote:
> Because it is not a common practice to test catalog dependency on
> separate tests (AFAICS initial catalogs are tested with oidjoins.sql).
> Also, your test case is too huge for such a small use case.

It seems oidjoins.sql is automatically generated and contains tests only for
initial database state. On the other hand, there are tests for CREATE OPERATOR
and ALTER OPERATOR, so it seems reasonable to me to have separate DROP OPERATOR
test, or to move all operator related testing to one file. This is however
clearly outside of the scope of this patch, so in v3 I've simplified tests using
queries from oidjoins.sql.

Cheers,
Roma



Attachment

pgsql-hackers by date:

Previous
From: Atri Sharma
Date:
Subject: Re: PROPOSAL: Fast temporary tables
Next
From: Joe Conway
Date:
Subject: Re: pg_dump dump catalog ACLs