Re: psql: show only failed queries - Mailing list pgsql-hackers

<div class="WordSection1"><p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">On</span><span
style="font-size:10.0pt;font-family:"Tahoma","sans-serif"">26June 2014 11:53, Samrat Revagade Wrote:</span><p
class="MsoNormal"><spanstyle="font-size:10.0pt;font-family:"Tahoma","sans-serif""> </span><p class="MsoNormal"><span
style="font-size:9.5pt;font-family:"Arial","sans-serif"">>>I am sending updated patch - buggy statement is
printedvia more logical psql_error function instead printf</span><p class="MsoNormal"><span
style="font-size:9.5pt;font-family:"Arial","sans-serif""> </span><pclass="MsoNormal"><span
style="font-size:9.5pt;font-family:"Arial","sans-serif"">>Thankyou for updating patch, I really appreciate your
efforts.</span><pclass="MsoNormal"><span style="font-size:9.5pt;font-family:"Arial","sans-serif""> </span><p
class="MsoNormal"><spanstyle="font-size:9.5pt;font-family:"Arial","sans-serif"">>Now, everything is good from my
side.</span><pclass="MsoNormal"><span style="font-size:9.5pt;font-family:"Arial","sans-serif"">>* <span
style="color:black">itapply cleanly to the current git master</span></span><p class="MsoNormal"><span
style="font-size:9.5pt;font-family:"Arial","sans-serif";color:black">>* includesnecessary docs</span><span
style="font-size:9.5pt;font-family:"Arial","sans-serif""></span><pclass="MsoNormal"><span
style="font-size:9.5pt;font-family:"Arial","sans-serif";color:black">>*I think It is very good  and necessary
feature.</span><spanstyle="font-size:9.5pt;font-family:"Arial","sans-serif""></span><p class="MsoNormal"><span
style="font-size:9.5pt;font-family:"Arial","sans-serif""> </span><pclass="MsoNormal"><span
style="font-size:9.5pt;font-family:"Arial","sans-serif";color:black">>If KumarRajeev Rastogi do not have any extra
comments,then I think patch is  ready for committer.</span><p class="MsoNormal"><span
style="font-size:9.5pt;font-family:"Arial","sans-serif""> </span><pclass="MsoNormal"><span
style="font-size:9.5pt;font-family:"Arial","sans-serif"">Ihave reviewed this patch. Please find my review comments
below:</span><pclass="MsoListParagraph" style="text-indent:-18.0pt;mso-list:l0 level1 lfo1"><span
style="font-size:9.5pt;font-family:"Arial","sans-serif";color:black"><spanstyle="mso-list:Ignore">1.<span
style="font:7.0pt"Times New Roman"">     </span></span></span><span
style="font-size:11.0pt;font-family:"Calibri","sans-serif"">Commandstart-up option (e.g. -a/--echo-all for --ECHO=all),
fornew functionality is not provided.</span><p class="MsoListParagraph" style="text-indent:-18.0pt;mso-list:l0 level1
lfo1"><spanstyle="font-size:9.5pt;font-family:"Arial","sans-serif";color:black"><span style="mso-list:Ignore">2.<span
style="font:7.0pt"Times New Roman"">     </span></span></span><span
style="font-size:11.0pt;font-family:"Calibri","sans-serif"">NewCommand start-up option should be added in "psql --help"
aswell as in documentation.</span><p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri","sans-serif""> </span><pclass="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri","sans-serif"">Alsoas I understand, this new option is kind of sub-set of
existingoption (ECHO=query), so should not we display</span><p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri","sans-serif"">querystring in the same format as it was getting printed
earlier.</span><pclass="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif"">Though I also feel
thatprefixing query with STATEMENT word will be helpful to grep but at the same time I am worried</span><p
class="MsoNormal"><spanstyle="font-size:11.0pt;font-family:"Calibri","sans-serif"">about inconsistency with existing
option.  </span><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif""> </span><p
class="MsoNormal"><i><spanstyle="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">Thanks and
Regards,</span></i><pclass="MsoNormal"><i><span
style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">KumarRajeev Rastogi </span></i></div>