Re: minor refactor on src/test/modules/test_ddl_deparse/sql/alter_table.sql - Mailing list pgsql-hackers

From Chao Li
Subject Re: minor refactor on src/test/modules/test_ddl_deparse/sql/alter_table.sql
Date
Msg-id BB3AE058-E281-4FA8-A6BC-747C7B552581@gmail.com
Whole thread Raw
In response to minor refactor on src/test/modules/test_ddl_deparse/sql/alter_table.sql  (jian he <jian.universality@gmail.com>)
List pgsql-hackers


On Aug 25, 2025, at 08:00, jian he <jian.universality@gmail.com> wrote:

hi.

in src/test/modules/test_ddl_deparse/sql/alter_table.sql:

----
The test initially focuses on the "parent" table, then switches to the "part"
table, and goes back to the "parent" table.
This seems weird?  so I slightly adjusted the order to cover the "parent"
table first, followed by the "part" table.

I think this change makes the test more organized.


src/test/modules/test_ddl_deparse/sql/alter_table.sql
don't have ALTER TABLE ALTER COLUMN SET EXPRESSION,
so I added a test on it.
<v1-0001-refactor-test_ddl_deparse-sql-alter_table.sql.patch>


I confirm “make check” passed with this patch.

--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/


pgsql-hackers by date:

Previous
From: Chao Li
Date:
Subject: Fixes a trivial bug in dumped parse/query/plan trees
Next
From: Yugo Nagata
Date:
Subject: Re: vacuumdb --missing-stats-only and permission issue