Re: [Patch] - Fix for bug #2558, InitDB failed to run - Mailing list pgsql-patches

Hi Andrew,
 
Regarding to your comments:
 
> 1. a patch is generated by the program "diff"
I will do it ,if needed

> 2. before we do anything, as Tom Lane says, we need verification of the 
> problem, preferably in writing from Microsoft.
I do understand that, but,  de-facto, the current implementation does not work, canceling the redirection (or open a log file) is not a matter of changing the OS behavior, therefore I don't see  why a formal verification from Microsoft is needed.
When this issue will be revealed in more and more system, it can be harmless to postgress reputation and critical problems for the end users.
In addition to the above,  as James Hughes have already mention before at item #2268 (http://archives.postgresql.org/pgsql-hackers/2006-03/msg00012.php):
He tried to get answers from microsoft but didn't get any respond.
 
Anyway,
 
For my own version, I solve the issue and built a private version, if you still want me to publish the patch (Just in case) I will do the diff and the effort needed, I don't think that Microsoft respond is needed in this case because it is implementation decision.
 
Regards;
 
Dror

---

> Date: Mon, 14 Aug 2006 17:42:58 -0400
> From: andrew@dunslane.net
> To: dror_b@hotmail.com
> CC: alvherre@commandprompt.com; pgsql-patches@postgresql.org
> Subject: Re: [PATCHES] [Patch] - Fix for bug #2558, InitDB failed to run
>
>
>
> 1. a patch is generated by the program "diff"
> 2. before we do anything, as Tom Lane says, we need verification of the 
> problem, preferably in writing from Microsoft.
>
> cheers
>
> andrew
>
>
> dror wrote:
> >
> >   1.
> >       When saying:
> >       "Please submit the changes as patches, instead of the whole files".  
> >       Do you mean to send each file seperately? or other issues as well?
> >   2.
> >       The change was test and design for 8.1.14, but as far as I see
> >       it is also true for any other version.
> >       Of course merge is needed in case that the files were changed
> >       since then, however , due to the fact that it is only few rows
> >       it will be easy to do it.
> >   3.
> >       Alvaro wrote:
> >       "it may be useful to lose the redirection only on the
> >        cases where it fails, so we still have reasonable behavior on non-broken
> >        platforms"
> >
> >       Nice idea, but it is really doesn't matter:  on other platform
> >       than win32, the code left unchanged! the fix is only relevant
> >       for win32 on which (as I explained) the MSI installer (if used)
> >       redirect the output by default to a log file.
> >
> > Regards
> > Dror
> > ------------------------------------------------------------------------
> >
> > > Date: Mon, 14 Aug 2006 12:40:25 -0400
> > > From: alvherre@commandprompt.com
> > > To: dror_b@hotmail.com
> > > CC: pgsql-patches@postgresql.org
> > > Subject: Re: [PATCHES] [Patch] - Fix for bug #2558, InitDB failed to 
> > run on windows 2003
> > >
> > > dror wrote:
> > >
> > > > There were two options to solve this issue:
> > > > 
> > > > Create a new file , grant a write permission for the Postgres user
> > > > and redirect the output to that file. (EnterpriseDB  use this method)
> > > > Canceling the redirection at all.
> > > >  
> > > > I choose the second option and omit the redirection in any case that
> > > > it windows machine and the redirection was sent to DEVNULL.
> > > >  
> > > > The only files that I changed are: initDB.c, exec.c and pg_ctl.c
> > >
> > > Please submit the changes as patches, instead of the whole files.  Also,
> > > please specify which branch do these patches apply -- is this for 8.1,
> > > or for the current development code?  When checked against the 8.1
> > > pg_ctl.c, the file you sent only contains a regression for a bug fix,
> > > and no change related to what you describe above.
> > >
> > > On the other hand, it may be useful to lose the redirection only on the
> > > cases where it fails, so we still have reasonable behavior on non-broken
> > > platforms.  Or maybe there's a better solution.
> > >
> > > -- 
> > > 
> > Alvaro Herrera                                http://www.CommandPrompt.com/
> > > PostgreSQL Replication, Consulting, Custom Development, 24x7 support
> >
> >
> > ------------------------------------------------------------------------
> > Express yourself instantly with Windows Live Messenger! Windows Live 
> > Messenger! 
> > <http://imagine-msn.com/messenger/launch80/default.aspx?locale=en-us&source=joinmsncom/messenger>
>

---

With MSN Spaces email straight to your blog. Upload jokes, photos and more. It's free! It's free!