On Mon, May 23, 2011 at 16:49, MauMau <maumau307@gmail.com> wrote:
> From: "Kevin Grittner" <Kevin.Grittner@wicourts.gov>
>>
>> "MauMau" <maumau307@gmail.com> wrote:
>>>
>>> Make pg_ctl's -s option suppress informational event logging.
>>
>> This will ultimately be up to a committer (and I'm not one), but to
>> me it seems reasonable to back-patch if it is addressed this way.
>>
>>
>>> the PostgreSQL Windows service must be registered by "pg_ctl
>>> register -s" to make use of this patch. However, according to the
>>> current manual, "pg_ctl register" does not take -s option.
>>> Actually, pg_ctl does not refuse to take -s, so this is not a big
>>> problem.
>>>
>>> pg_ctl register [-N servicename] [-U username] [-P password]
>>> [-D datadir] [-w] [-t seconds] [-o options]
>>
>> When you write the patch, be sure to include a fix for the docs
>> here, please.
>>
>
> I attached a patch to fix this bug. I performed the following tests
> successfully on Windows Vista (32-bit).
>
<snip test cases>
> I wish this will be back-patched in the next minor release.
Thanks, sorry about the delay, patch applied. I backpatched it back to
8.3 which is as far as it applied cleanly - I'm not excited enough
about it to bother a manual backpatch to 8.2.
--
Magnus Hagander
Me: http://www.hagander.net/
Work: http://www.redpill-linpro.com/
