Re: psql describe.c cleanup - Mailing list pgsql-hackers

From Merlin Moncure
Subject Re: psql describe.c cleanup
Date
Msg-id BANLkTik31_V=6P=SyBJR9XQA1+bSEpxeaw@mail.gmail.com
Whole thread Raw
In response to Re: psql describe.c cleanup  (Josh Kupershmidt <schmiddy@gmail.com>)
Responses Re: psql describe.c cleanup
List pgsql-hackers
On Tue, Jun 14, 2011 at 9:08 PM, Josh Kupershmidt <schmiddy@gmail.com> wrote:
> On Tue, Jun 14, 2011 at 12:15 PM, Merlin Moncure <mmoncure@gmail.com> wrote:
>> What I do wonder though is if the ; appending should really be
>> happening in printQuery() instead of in each query -- the idea being
>> that formatting for external consumption should be happening in one
>> place.  Maybe that's over-thinking it though.
>
> That's a fair point, and hacking up printQuery() would indeed solve my
> original gripe about copy-pasting queries out of psql -E. But more
> generally, I think that standardizing the style of the code is a Good
> Thing, particularly where style issues impact usability (like here).

sure -- if anyone would like to comment on this one way or the other
feel free -- otherwise I'll pass the patch up the chain as-is...it's
not exactly the 'debate of the century' :-).

merlin


pgsql-hackers by date:

Previous
From: Gurjeet Singh
Date:
Subject: Re: procpid?
Next
From: Andrew Dunstan
Date:
Subject: Re: pg_upgrade using appname to lock out other users