Re: COPY JSON: use trailing commas in FORCE_ARRAY output - Mailing list pgsql-hackers

From Daniel Gustafsson
Subject Re: COPY JSON: use trailing commas in FORCE_ARRAY output
Date
Msg-id B774FE54-19BB-4250-AF2E-967460816C1F@yesql.se
Whole thread
In response to COPY JSON: use trailing commas in FORCE_ARRAY output  (Chao Li <li.evan.chao@gmail.com>)
Responses Re: COPY JSON: use trailing commas in FORCE_ARRAY output
List pgsql-hackers
> On 6 May 2026, at 08:40, Chao Li <li.evan.chao@gmail.com> wrote:

> I was surprised by the comma placement. It is valid JSON, but it looks quite uncommon.

It might look uncommon, but for very wide lines it's IMHO preferrable to not
have to scroll all the way to the end of the line to know that the line is part
of an array.

> For comparison, the existing json_agg() places commas at the end of the line:

That's true, but json_agg() and COPY TO in ndjson format have different use
cases.

> ..it should not have any performance impact.

It does add branches though, and in one branch use a non-inlined function where
previously it would unconditionally use an inline function.  ISTM it would
still be valuable to do performance testing given that COPY is commonly used in
performance sensitive settings.

--
Daniel Gustafsson




pgsql-hackers by date:

Previous
From: Anthonin Bonnefoy
Date:
Subject: Re: Server crash: Use-after-free in AfterTriggerEndQuery()
Next
From: Jelte Fennema-Nio
Date:
Subject: Re: PSA: Planning to grease protocol connections during 19beta