Re: Fix incorrect assignment for nodeid in TransactionIdGetCommitTsData() - Mailing list pgsql-hackers

> On Feb 5, 2026, at 23:00, Ashutosh Bapat <ashutosh.bapat.oss@gmail.com> wrote:
>
> On Thu, Feb 5, 2026 at 9:09 AM wangpeng <215722532@qq.com> wrote:
>>
>> Hi hackers,
>>
>> This is my first patch
>
> Welcome to the community.
>
>> There is an incorrect assignment of nodeid = 0 in
>> TransactionIdGetCommitTsData() (commit_ts.c).
>> Elsewhere in the file, the code consistently uses InvalidReplOriginId.
>> Even though InvalidReplOriginId also evaluates to 0, it should be used
>> here for clarity and consistency.
>
> Few lines below we have a similar assignment which uses
> InvalidReplOriginId. I agree with your suggestion. Patch LGTM. It's an
> old and small commit so maybe Alvaro, who committed the change
> (4aaddf2f009821e29aea3735e44332ad9ca47aaa), may not remember it. Still
> including him in case.
>
> --
> Best Wishes,
> Ashutosh Bapat
>
>

+1. I saw a recent commit, ec317440716487753bafa4c0f8adae53e2c32446, which replaces 0 with InvalidXLogRecPtr, so this
patchis similar. The main difference is that ec3174407 does a broad sweep replacing 0 wherever possible, while this
patchjust fixes one remaining omission. 

So if this patch is considered too trivial, I think it’s still worth a place in Michael’s stack for later.

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/