Re: Fixed a typo in comment in compress_lz4.c - Mailing list pgsql-hackers

From Chao Li
Subject Re: Fixed a typo in comment in compress_lz4.c
Date
Msg-id B6C167ED-DE33-4B67-AB9A-AB08904E14F9@gmail.com
Whole thread Raw
In response to Re: Fixed a typo in comment in compress_lz4.c  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers


On Oct 14, 2025, at 08:12, Tom Lane <tgl@sss.pgh.pa.us> wrote:

Chao Li <li.evan.chao@gmail.com> writes:
Look at this instance. The comment says:

 * LZ4 equivalent to feof() or gzeof().  Return true iff there is no
 * more buffered data and the end of the input file has been reached.

It just states when the function should return true. In this case, why “if” is not good enough and “if and only if” is needed?

Saying "if" here wouldn't fully specify the behavior.  As an example,
returning constant-true would formally satisfy such a definition.
Yeah, most people would understand what is meant, but if you want
to be precise then you must make clear that the function doesn't
return true when the condition is not satisfied.

I believe that the abbreviation "iff" arose among mathematicians,
who are much more likely to be concerned about such precision than
many of us.

regards, tom lane

Okay, I see. In other words, if we were replacing “iff”, “only when” would be more precise than “if”.

I think we can leave existing “iff” there. I withdraw this patch.

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/




pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Fixed a typo in comment in compress_lz4.c
Next
From: Tom Lane
Date:
Subject: Re: [PING] [PATCH v2] parallel pg_restore: avoid disk seeks when jumping short distance forward