Re: Re: [COMMITTERS] pgsql: Add support for INSERT ... ON CONFLICT DO NOTHING/UPDATE. - Mailing list pgsql-hackers

From Robert Haas
Subject Re: Re: [COMMITTERS] pgsql: Add support for INSERT ... ON CONFLICT DO NOTHING/UPDATE.
Date
Msg-id B66C0757-BD88-499C-BF68-214F4BBAFEAE@gmail.com
Whole thread Raw
In response to Re: Re: [COMMITTERS] pgsql: Add support for INSERT ... ON CONFLICT DO NOTHING/UPDATE.  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On May 20, 2015, at 9:22 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Andres Freund <andres@anarazel.de> writes:
>> You realize there's other instances of this in the same damn function?
> 
> Not to mention that several places in libpq/fe-exec.c should be
> taught about this new tag.  And who-knows-what in other client-side
> libraries.  I am not really sure that it was a good idea to invent
> this command tag.  In fact, I'm pretty sure it was a *bad* idea ---
> what will happen if we ever create a statement actually named UPSERT?
> 
> I think we should fix this by ripping out the variant tag, not trying
> to propagate it everywhere it would need to go.

+1

...Robert



pgsql-hackers by date:

Previous
From: Jan Bilek
Date:
Subject: Postgres and TLSv1.2
Next
From: Grigory Kareev
Date:
Subject: Add support for interface/ipaddress binding to libpq