Re: pgsql: Remove the adminpack contrib extension - Mailing list pgsql-committers

From Daniel Gustafsson
Subject Re: pgsql: Remove the adminpack contrib extension
Date
Msg-id B5FC1FD8-01ED-4C22-BE98-8D483000E331@yesql.se
Whole thread Raw
In response to Re: pgsql: Remove the adminpack contrib extension  (Tom Lane <tgl@sss.pgh.pa.us>)
Responses Re: pgsql: Remove the adminpack contrib extension
List pgsql-committers
> On 4 Mar 2024, at 17:34, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>
> Daniel Gustafsson <daniel@yesql.se> writes:
>> I see that my fix didn't solve it for 11 and 9.x on crake and drongo, will
>> rebuild more old trees and test to find the correct fix.
>
> The oldest branches didn't make that DB, so you need an "IF EXISTS".
> I pushed a fix after quickly checking it here.

Thanks for fixing, much appreciated!

The deviation between database names on crake found in the follow-up commit is
a bit concerning.  Too much magic hidden away from the codetree makes it hard
to get tests right on the first try.

--
Daniel Gustafsson




pgsql-committers by date:

Previous
From: Robert Haas
Date:
Subject: pgsql: Fix incremental backup interaction with XLOG_DBASE_CREATE_FILE_C
Next
From: Robert Haas
Date:
Subject: pgsql: Fix pgindent damage.