Re: On login trigger: take three - Mailing list pgsql-hackers

From Daniel Gustafsson
Subject Re: On login trigger: take three
Date
Msg-id B4DCB4BA-6103-4D86-8AD4-D62BEBE6837F@yesql.se
Whole thread Raw
In response to Re[2]: On login trigger: take three  (Ivan Panchenko <wao@mail.ru>)
Responses Re: On login trigger: take three  (a.sokolov@postgrespro.ru)
List pgsql-hackers
> On 30 Mar 2022, at 13:21, Ivan Panchenko <wao@mail.ru> wrote:
> Maybe side-effects is a bit too general? Emitting a log message, rejecting a
> login, setting some GUCs, etc are all side-effects too.
> Something like this:

I've reworded the docs close to what you suggested here.

> Also, please fix a typo in doc/src/sgml/ref/create_event_trigger.sgml :

Done.

> Regarding the trigger function example:
> It does not do anything if run on a standby. To show that it can do something on a standby to, I propose to move
throwingthe night exception to the beginning. 

Good idea, done.

> Finally, let me propose to append to the regression test the following:

Also a good idea, done.

--
Daniel Gustafsson        https://vmware.com/


Attachment

pgsql-hackers by date:

Previous
From: Justin Pryzby
Date:
Subject: Re: In-placre persistance change of a relation
Next
From: Daniel Gustafsson
Date:
Subject: Re: On login trigger: take three