Re: perlcritic: prohibit map and grep in void conext - Mailing list pgsql-hackers

From Daniel Gustafsson
Subject Re: perlcritic: prohibit map and grep in void conext
Date
Msg-id B10A5F4F-ACB6-4B47-9E96-7855FEB0AEB5@yesql.se
Whole thread Raw
In response to perlcritic: prohibit map and grep in void conext  (ilmari@ilmari.org (Dagfinn Ilmari Mannsåker))
List pgsql-hackers
> On 27 Jul 2021, at 18:06, Dagfinn Ilmari Mannsåker <ilmari@ilmari.org> wrote:

> Attached is a patch that increases severity of that and the
> corresponding `grep` policy to 5 to enable it in our perlcritic policy,
> and fixes the one use that had already snuck in.

+1, the use of foreach also improves readability a fair bit IMO.

--
Daniel Gustafsson        https://vmware.com/




pgsql-hackers by date:

Previous
From: Pavel Stehule
Date:
Subject: Re: RFC: Logging plan of the running query
Next
From: Bruce Momjian
Date:
Subject: Re: Have I found an interval arithmetic bug?