Re: Possibility to disable `ALTER SYSTEM` - Mailing list pgsql-hackers

From Daniel Gustafsson
Subject Re: Possibility to disable `ALTER SYSTEM`
Date
Msg-id B0918797-FCC8-4E81-8CD7-0AFC8E798830@yesql.se
Whole thread Raw
In response to Re: Possibility to disable `ALTER SYSTEM`  (Magnus Hagander <magnus@hagander.net>)
Responses Re: Possibility to disable `ALTER SYSTEM`
List pgsql-hackers
> On 18 Mar 2024, at 16:34, Magnus Hagander <magnus@hagander.net> wrote:
>
> On Mon, Mar 18, 2024 at 2:09 PM Daniel Gustafsson <daniel@yesql.se> wrote:
>>
>>> On 18 Mar 2024, at 13:57, Robert Haas <robertmhaas@gmail.com> wrote:
>>
>>> my proposal is something like this, taking a
>>> bunch of text from Jelte's patch and some inspiration from Magnus's
>>> earlier remarks:
>>
>> I still think any wording should clearly mention that settings in the file are
>> still applied.  The proposed wording says to implicitly but to avoid confusion
>> I think it should be explicit.
>
> I haven't kept up with the thread, but in general I'd prefer it to
> actually turn off parsing the file as well. I think just turning off
> the ability to change it -- including the ability to *revert* changes
> that were made to it before -- is going to be confusing.

Wouldn't that break pgBackrest which IIRC write to .auto.conf directly
without using ALTER SYSTEM?

> But, if we have decided it shouldn't do that, then IMHO we should
> consider naming it maybe enable_alter_system_command instead -- since
> we're only disabling the alter system command, not the actual feature
> in total.

Good point.

--
Daniel Gustafsson




pgsql-hackers by date:

Previous
From: Tom Lane
Date:
Subject: Re: Add pg_basetype() function to obtain a DOMAIN base type
Next
From: Magnus Hagander
Date:
Subject: Re: Possibility to disable `ALTER SYSTEM`