Re: pg_execute_from_file, patch v10 - Mailing list pgsql-hackers

From Robert Haas
Subject Re: pg_execute_from_file, patch v10
Date
Msg-id AANLkTindk4tL=AHSwbaa1Uhb2zUik1mGbp3gPACUWWF1@mail.gmail.com
Whole thread Raw
In response to Re: pg_execute_from_file, patch v10  (Dimitri Fontaine <dimitri@2ndQuadrant.fr>)
Responses Re: pg_execute_from_file, patch v10  (Itagaki Takahiro <itagaki.takahiro@gmail.com>)
List pgsql-hackers
On Mon, Dec 13, 2010 at 9:36 AM, Dimitri Fontaine
<dimitri@2ndquadrant.fr> wrote:
> Do you want another patch version from me?

I'm looking at this patch and I'm confused.  Why do we need this at
all?  pg_read_binary_file() seems like it might be useful to somebody,
but I don't see what it has to do with extensions.  And the rest of
this doesn't appear to provide any new functionality.  The extension
mechanism hardly needs SQL-callable functions.

As a side note, this comment almost makes sense, but not quite:

+       /* Abuse knowledge that we're bytea and text are both varlena */

...but my real question is why any of this is necessary at all and
what it has to do with extensions.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: rest of works for security providers in v9.1
Next
From: KaiGai Kohei
Date:
Subject: Re: rest of works for security providers in v9.1