Re: comments on type attributes broken in 9.1devel - Mailing list pgsql-hackers

From Robert Haas
Subject Re: comments on type attributes broken in 9.1devel
Date
Msg-id AANLkTinSg-fLZgh_hhebvL6_z=1-rpXC8EZfAcZXOco9@mail.gmail.com
Whole thread Raw
In response to comments on type attributes broken in 9.1devel  (Peter Eisentraut <peter_e@gmx.net>)
List pgsql-hackers
On Tue, Oct 19, 2010 at 1:46 AM, Peter Eisentraut <peter_e@gmx.net> wrote:
> The comment code refactoring c10575ff005c330d0475345621b7d381eb510c48
> broke comments on composite type attributes:
>
> COMMENT ON COLUMN foo.a is 'test';
> ERROR:  42809: "foo" is a composite type
> LOCATION:  heap_openrv, heapam.c:1110
>
> This is because as the code was moved from CommentAttribute() to
> get_object_address_attribute(), the call to relation_openrv() became a
> heap_openrv(), which causes the above error.
>
> Please check it out.

Thanks.  I changed that and added a regression test.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


pgsql-hackers by date:

Previous
From: Magnus Hagander
Date:
Subject: Re: max_wal_senders must die
Next
From: Stefan Kaltenbrunner
Date:
Subject: Re: max_wal_senders must die