On Sat, Jan 22, 2011 at 18:12, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Andrew Dunstan <andrew@dunslane.net> writes:
>> This appears to have broken Solaris, Unixware and MSVC builds.
>
> BTW, the MSVC problem appears to stem from failure to include libpgport
> when linking pg_test_fsync. I imagine this requires a fix in the MSVC
> build scripts.
Yup, fixed and pushed.
I still get:
pg_test_fsync.c
1>.\contrib\pg_test_fsync\pg_test_fsync.c(398) : warning C4101: 'ops'
: unreferenced local variable
1>.\contrib\pg_test_fsync\pg_test_fsync.c(398) : warning C4101:
'writes' : unreferenced local variable
1>.\contrib\pg_test_fsync\pg_test_fsync.c(398) : warning C4101:
'tmpfile' : unreferenced local variable
ISTM that the declaration of variables should be moved inside the #ifdef, no?
--
Magnus Hagander
Me: http://www.hagander.net/
Work: http://www.redpill-linpro.com/
