Re: Tab completion for view triggers in psql - Mailing list pgsql-hackers

From Itagaki Takahiro
Subject Re: Tab completion for view triggers in psql
Date
Msg-id AANLkTimh=mfPoa8YG78UfCZdQ9JNDEKcaTbRis6vJrZ7@mail.gmail.com
Whole thread Raw
In response to Re: Tab completion for view triggers in psql  (David Fetter <david@fetter.org>)
Responses Re: Tab completion for view triggers in psql
List pgsql-hackers
On Tue, Nov 30, 2010 at 18:18, David Fetter <david@fetter.org> wrote:
>> It expands all tables (and views) in tab-completion after INSERT,
>> UPDATE, and DELETE FROM.  Is it an intended change?

I found it was a simple bug; we need ( ) around selcondition.

In addition, I modified your patch a bit:

* I added a separated CREATE TRIGGER INSTEAD OF if-branch
  because it doesn't accept tables actually; it only accepts
  views. OTOH, BEFORE or AFTER only accepts tables.

* I think "t.tgtype & (1 << N) <> 0" is more natural
  bit operation than "t.tgtype | (1 << N) = t.tgtype".

Patch attached. If you think my changes are ok,
please change the patch status to "Ready for Committer".

--
Itagaki Takahiro

Attachment

pgsql-hackers by date:

Previous
From: Heikki Linnakangas
Date:
Subject: Re: GiST insert algorithm rewrite
Next
From: Csaba Nagy
Date:
Subject: Re: DELETE with LIMIT (or my first hack)