Re: pgAdmin III commit: Revert the previous change that introduced sysSetti - Mailing list pgadmin-hackers

From Peter Geoghegan
Subject Re: pgAdmin III commit: Revert the previous change that introduced sysSetti
Date
Msg-id AANLkTimdfdhBpFo7Pn19gANU3SGhDuvCNckBRC1YLV1D@mail.gmail.com
Whole thread Raw
In response to Re: pgAdmin III commit: Revert the previous change that introduced sysSetti  (Dave Page <dpage@pgadmin.org>)
Responses Re: pgAdmin III commit: Revert the previous change that introduced sysSetti
List pgadmin-hackers
On 18 February 2011 16:46, Dave Page <dpage@pgadmin.org> wrote:
> I'm not sure that helps - the issue is that the current code reads the
> string "true" and treats it as a boolean. What we need to do is ensure
> we always write booleans as strings, otherwise it won't be backwards
> compatible. Then, ReadBool() just reads a string value, and converts
> it.

Sure, we should be calling exactly the same function, but with a
slightly different interface (at least in the case of write()
variants). I thought that the interface inconsistency between read()
and write() variants might be a problem for you.


--
Regards,
Peter Geoghegan

pgadmin-hackers by date:

Previous
From: Dave Page
Date:
Subject: Re: pgAdmin III commit: Revert the previous change that introduced sysSetti
Next
From: Peter Geoghegan
Date:
Subject: Re: pgAdmin III commit: Revert the previous change that introduced sysSetti