Re: patch: SQL/MED(FDW) DDL - Mailing list pgsql-hackers

From Itagaki Takahiro
Subject Re: patch: SQL/MED(FDW) DDL
Date
Msg-id AANLkTimdXSvpK_R=KAvJCEKMUn_G_X+_c5JF7Tr5GP5x@mail.gmail.com
Whole thread Raw
In response to Re: patch: SQL/MED(FDW) DDL  (Robert Haas <robertmhaas@gmail.com>)
Responses Re: patch: SQL/MED(FDW) DDL
Re: patch: SQL/MED(FDW) DDL
List pgsql-hackers
On Fri, Sep 24, 2010 at 12:08 PM, Robert Haas <robertmhaas@gmail.com> wrote:
> I think we need to further discuss how this is eventually going to get
> integrated with the query planner and the executor before we commit
> anything.  The syntax support by itself is quite trivial.

There are no active discussions :-(  I think the author tried his best, so if
other developers think it's a bad design, alternate plan must be proposed.

Also, if the syntax change is trivial, that's why we merge it at
earlier commitfests. I saw many patch went into "No patch reviewers
because of too large size" syndrome before. DDL changes are 5K
lines of diff -c patch, and "select" part is additional 6K lines.

--
Itagaki Takahiro


pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: patch: SQL/MED(FDW) DDL
Next
From: Tom Lane
Date:
Subject: Re: security label support, revised