Re: Instrument checkpoint sync calls - Mailing list pgsql-hackers

From Jeff Janes
Subject Re: Instrument checkpoint sync calls
Date
Msg-id AANLkTimOw48vy3kznwjQQmGWzCDQp=mVGOO=ZvLJzEy2@mail.gmail.com
Whole thread Raw
In response to Re: Instrument checkpoint sync calls  (Greg Smith <greg@2ndquadrant.com>)
Responses Re: Instrument checkpoint sync calls
Re: Instrument checkpoint sync calls
List pgsql-hackers
On Mon, Nov 15, 2010 at 12:09 PM, Greg Smith <greg@2ndquadrant.com> wrote:
> So my task list is:
>
> 0) Rebase against the HEAD that just code related to this touched today
>
> 1) Assume that log_checkpoints is sufficient control over whether the timing
> overhead added is worth collecting, and therefore remove the half-baked idea
> of also wrapping with a compile-time option.
>
> 2) Have the sync summary returned upwards, so it can be put onto the same
> line as the rest of the rest of the log_checkpoint info.
>
> All seems reasonable to me.  Will rev a new patch by tomorrow.

For the individual file sync times emitted under debug1, it would be
very handy if the file being synced was identified, for example
"relation base/16384/16523". Rather than being numbered sequentially
within a given checkpoint.

Cheers,

Jeff


pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: visibility map
Next
From: Robert Haas
Date:
Subject: Re: Re: Proposed Windows-specific change: Enable crash dumps (like core files)