Re: Email notification pgAgent - Mailing list pgadmin-hackers
| From | Jasmin Dizdarevic |
|---|---|
| Subject | Re: Email notification pgAgent |
| Date | |
| Msg-id | AANLkTim0hOy09WXRisqh63ze+dymCKbfmcJ8=cQKcqpd@mail.gmail.com Whole thread Raw |
| In response to | Re: Email notification pgAgent (Dave Page <dpage@pgadmin.org>) |
| Responses |
Re: Email notification pgAgent
(Dave Page <dpage@pgadmin.org>)
|
| List | pgadmin-hackers |
Hi,
I've made the necessary changes to pgAdmin, but how do we handle schema version conflicts?
pgAdmin's job UI now will not work with pgAgent schema version 3, because of the changes in pgagent.pga_job table. I think we have two possibilities:
1. Disable editing Jobs in pgAdmin until a schema upgrade is done
2. Check schema version during GetUpdateSql and GetInsertSql and return two different versions of the statement.
What do you think?
I've got another two topics to discuss about pgAgent:
1. Step ordering
I suggest adding a column named "jstorder" to pgagent.pga_jobsteps, so we don't have to rename the steps "A_", "B_" if an ordering is required. In the GUI we would add an integer field to the "Change Step" mask.
2. Definition from File
Add an extra job step type "SQL from file". The definition field would be treated as a path to a file, which contains SQL-Statements.
Please let me know what you (all of you) think about the suggested features.
Regards,
Jasmin
2010/12/29 Dave Page <dpage@pgadmin.org>
Hi
On Tue, Dec 28, 2010 at 1:54 AM, Jasmin Dizdarevic<jasmin.dizdarevic@gmail.com> wrote:> Okay, I'm almost done. Actually there is a problem with building the wxSMTPOk.
> package, so it doesn't send mails yet.
> If this is done, I'm going to test it on Windows and *nix.You need to update the CMakeLists.txt file from which the VC++ project
> Time to take care about some other things:
> 1. I'm coding on Windows with VS 2010. I've downloaded the source files and
> run cmake to get a VS-Project. Here i made the changes. How I can generate a
> patch file with git now, because I'm not working on the original source
> files - because of the cmake step? Have I to redo the changes on *nix?
file and *nix build files are generated.Just send a patch (git diff) to pgadmin-hackers@postgresql.org.
> 2. What steps are necessary to send the changes to the community? Is there aThe maintainers of pgAdmin are the same people, and no, they won't
> desired process and what's about the necessary changes in the pgAdmin UI?
> Will they be done by the maintainer of pgAdmin? Of course I'm ready to
> participate in pgAdmin too, but my knowledge of C++ and wx are limited, so I
> can not promise best quality ;)
automatically update the UI for the new feature I'm afraid (they have
enough work to do just keeping up with changes in PostgreSQL). Please
give it a try yourself, and we can help you iron out any kinks or
issues you may run into.
Regards, Dave
--Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
pgadmin-hackers by date: