Re: Re: starting to review the Extend NOT NULL representation to pg_constraint patch - Mailing list pgsql-hackers

From Dean Rasheed
Subject Re: Re: starting to review the Extend NOT NULL representation to pg_constraint patch
Date
Msg-id AANLkTikucgmzvrJru5A30Q3GJGTZ+4FLb02Fja-eqf-6@mail.gmail.com
Whole thread Raw
In response to Re: Re: starting to review the Extend NOT NULL representation to pg_constraint patch  (Alvaro Herrera <alvherre@commandprompt.com>)
Responses Re: Re: starting to review the Extend NOT NULL representation to pg_constraint patch
List pgsql-hackers
On 14 October 2010 20:28, Alvaro Herrera <alvherre@commandprompt.com> wrote:
>> Looking in that function, there is a similar "found" variable that
>> isn't being initialised (which my compiler didn't warn about).
>> Initialising that to false, sems to fix the problem and all the
>> regression tests then pass.
>
> Excellent.  Please send an updated patch.
>

OK, here it is.

I've not cured this compiler warning (in fact I'm not sure what it's
complaining about, because the variable *is* used):

tablecmds.c: In function 'ATExecSetNotNull':
tablecmds.c:4747: warning: unused variable 'is_new_constraint'

Regards,
Dean

Attachment

pgsql-hackers by date:

Previous
From: Darth Revan
Date:
Subject: Darth Revan wants to chat
Next
From: Bernd Helmle
Date:
Subject: Re: Re: starting to review the Extend NOT NULL representation to pg_constraint patch