Re: multiset patch review - Mailing list pgsql-hackers

From Robert Haas
Subject Re: multiset patch review
Date
Msg-id AANLkTikU_AX+v1FoTrmiHuO8F=X9iekSDRAGTBGhnVmB@mail.gmail.com
Whole thread Raw
In response to Re: multiset patch review  (Itagaki Takahiro <itagaki.takahiro@gmail.com>)
Responses Re: multiset patch review  (Robert Haas <robertmhaas@gmail.com>)
List pgsql-hackers
On Tue, Feb 15, 2011 at 4:31 AM, Itagaki Takahiro
<itagaki.takahiro@gmail.com> wrote:
> array_flatten() no longer exists. I added array_trim() as an alias
> to trim_array() because it would be a FAQ.

I don't like the alias thing - let's add one name or the other, not both.

Similarly, let's NOT add array_union_all as an alias for array_concat.

'cannot use multi-dimensional arrays' reads awkwardly to me.  I think
it should say something like "sorting of multi-dimensional arrays is
not supported".

multi-demensional -> multi-dimensional

slaces -> slices

The formula in the trim_array comment is apparently misparenthesized.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: CommitFest 2011-01 as of 2011-02-04
Next
From: Robert Haas
Date:
Subject: Re: Change pg_last_xlog_receive_location not to move backwards