Re: Parallel restore checks wrong thread return value? - Mailing list pgsql-hackers

From Magnus Hagander
Subject Re: Parallel restore checks wrong thread return value?
Date
Msg-id AANLkTi=x4sq5Q5M1UnnazDw8AdeTk_vpNkbCREC=aF4T@mail.gmail.com
Whole thread Raw
In response to Parallel restore checks wrong thread return value?  (Magnus Hagander <magnus@hagander.net>)
List pgsql-hackers
On Sat, Feb 26, 2011 at 16:51, Magnus Hagander <magnus@hagander.net> wrote:
> in spawn_restore:
>
>
>        child = (HANDLE) _beginthreadex(NULL, 0, (void *) parallel_restore,
>                                                                        args, 0, NULL);
>        if (child == 0)
>
>
> But from my reading of the docs, _beginthreadex() returns -1 on error, not 0.
>
> Bug, or am I reading it wrong?

I was.

_beginthread() returns -1 on error, and _beginthreadex() returns 0.

That's just brilliant.

Sorry about the noise.

--
 Magnus Hagander
 Me: http://www.hagander.net/
 Work: http://www.redpill-linpro.com/


pgsql-hackers by date:

Previous
From: Greg Stark
Date:
Subject: Re: wCTE: why not finish sub-updates at the end, not the beginning?
Next
From: Magnus Hagander
Date:
Subject: Re: pg_basebackup and wal streaming