Re: do we want to gitignore regression-test-failure files? - Mailing list pgsql-hackers

From Robert Haas
Subject Re: do we want to gitignore regression-test-failure files?
Date
Msg-id AANLkTi=nQOAEdTyZhSS2FNzvkTqAmKqaAL5S7L=4RfhM@mail.gmail.com
Whole thread Raw
In response to Re: do we want to gitignore regression-test-failure files?  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On Sun, Sep 26, 2010 at 4:28 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> The reason I assumed we'd want to ignore these is because they're
>> automatically generated files - unlike *.rej files, which are never
>> going to end up in your tree as a result of make anything.  It doesn't
>> actually matter that much to me in practice, except that I fear
>> creating a complex and indecipherable rule about what to ignore vs.
>> not.
>
> I don't find it indecipherable.  We're ignoring stuff that can be
> expected to be present after a normal build and successful "make
> check" or "make installcheck".  As soon as we ignore more than that,
> I'm going to insist on ignoring *~ ... do you want to open that can
> of worms?

What is this, some kind of game of chicken?  Surely we're trying to
settle on a sensible rule here, not get into a mud-wrestling match.  I
can live with the rule you've articulated but I think it's more
complicated than necessary, and I certainly don't want to see it
further complicated.  Let's get it written down in a README file
someplace and not be moving the goalposts henceforth.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise Postgres Company


pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: [COMMITTERS] pgsql: Still more tweaking of git_changelog.
Next
From: Thom Brown
Date:
Subject: recovery.conf location