Re: Why assignment before return? - Mailing list pgsql-hackers

From Magnus Hagander
Subject Re: Why assignment before return?
Date
Msg-id AANLkTi=S5gkt4yFrF77fQzM2-c6vs-3QVYmgi996o6G2@mail.gmail.com
Whole thread Raw
In response to Re: Why assignment before return?  (Tom Lane <tgl@sss.pgh.pa.us>)
List pgsql-hackers
On Fri, Aug 20, 2010 at 15:27, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Magnus Hagander <magnus@hagander.net> writes:
>> I see your answer as "no, not really any reason, but also not worth
>> changing", which is fine by me :-)
>
> Yeah, that's a fair summary.  If it had been coded the other way
> to start with, I'd also say it wasn't worth changing, at least
> not until such time as we actually needed to.
>
> In the meantime, any added functions of the same ilk should definitely
> be made to look like the existing ones.

Yeah. I notice there are some functions that are not following this
pattern, but most are, so I'll adjust my patch with this.


--
 Magnus Hagander
 Me: http://www.hagander.net/
 Work: http://www.redpill-linpro.com/


pgsql-hackers by date:

Previous
From: Robert Haas
Date:
Subject: Re: small smgrcreate cleanup patch
Next
From: Tom Lane
Date:
Subject: Re: small smgrcreate cleanup patch