Postgres Pro
Downloads
Home   >   mailing lists

Re: pgAdmin III commit: Somehow forgot to commit this. - Mailing list pgadmin-hackers

From Dave Page
Subject Re: pgAdmin III commit: Somehow forgot to commit this.
Date
Msg-id AANLkTi=J4XWxPnu+ScAdAOfckUi7H0nCkEBH30KTXxSX@mail.gmail.com
Whole thread Raw
In response to Re: pgAdmin III commit: Somehow forgot to commit this.  (Peter Geoghegan <peter.geoghegan86@gmail.com>)
Responses Re: pgAdmin III commit: Somehow forgot to commit this.
List pgadmin-hackers
Tree view 
On Wed, Feb 16, 2011 at 1:21 PM, Peter Geoghegan
<peter.geoghegan86@gmail.com> wrote:
> uh, what about the patch I sent you last night,
> patch_with_ogl.patch.gz? It integrated OGL into our tree.
>

Gimme a chance - that was code which was in my tree when I applied
Nikhil's patch from last week! Yours is further back in the queue :-(

> By the way, this shouldn't have been changed, and has been changed
> back in that patch:
>    //Create SQL editor notebook
>    sqlNotebook = new ctlAuiNotebook(this, CTL_NTBKCENTER,
> wxDefaultPosition, wxDefaultSize, wxAUI_NB_TOP | wxAUI_NB_TAB_SPLIT |
> wxAUI_NB_TAB_MOVE | wxAUI_NB_SCROLL_BUTTONS |
> wxAUI_NB_WINDOWLIST_BUTTON);
> @@ -994,7 +994,7 @@ void frmQuery::OnChangeConnection(wxCommandEvent &ev)
>            pgConn *newconn = dlg.CreateConn(applicationname, createdNewConn);
>            if (newconn && createdNewConn)
>            {
> -               cbConnection->Insert(newconn->GetName(),
> CreateBitmap(GetServerColour(newconn)), sel, (void *)newconn);
> +               cbConnection->Insert(newconn->GetName(),
> CreateBitmap(GetServerColour(newconn)), sel, (wxClientData *)newconn);

Fixed, thanks.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

pgadmin-hackers by date:

Previous
From: Dave Page
Date:
Subject: pgAdmin III commit: Revert change to cast, per Peter.
Next
From: Peter Geoghegan
Date:
Subject: Re: pgAdmin III commit: Somehow forgot to commit this.