walsender parser patch - Mailing list pgsql-hackers

From Magnus Hagander
Subject walsender parser patch
Date
Msg-id AANLkTi=Aw1gT9X88AxjgxpuRYaGVXgh+3sc-q=n97A5m@mail.gmail.com
Whole thread Raw
Responses Re: walsender parser patch  (Dimitri Fontaine <dimitri@2ndQuadrant.fr>)
List pgsql-hackers
Attached is an updated version of Heikki's patch to use a parser for
the walsender commands, instead of parsing things manually. It also
does some minor refactoring in walsender.c to break out
IdentifySystem() and StartReplication() to their own functions to make
it more readable.

While having an actual parser here isn't *necessary* at this point, it
makes things easier. And it will become increasingly useful as we add
new features (for example, the "include all wal files" option for
streaming base backup, and I'm sure that sync rep will require some
additional commands or changes to commands).

Any objections to doing this?

--
 Magnus Hagander
 Me: http://www.hagander.net/
 Work: http://www.redpill-linpro.com/

Attachment

pgsql-hackers by date:

Previous
From: Andreas Karlsson
Date:
Subject: Bug in pg_describe_object (was: Re: [HACKERS] obj_unique_identifier(oid))
Next
From: Joel Jacobson
Date:
Subject: Re: Bug in pg_describe_object (was: Re: [HACKERS] obj_unique_identifier(oid))