Re: Review: Patch for phypot - Pygmy Hippotause - Mailing list pgsql-hackers

From Andrew Geery
Subject Re: Review: Patch for phypot - Pygmy Hippotause
Date
Msg-id AANLkTi=-_yKXZW-a=J5WEX2FquVvCusR3e9MYR-j9LOb@mail.gmail.com
Whole thread Raw
In response to Re: Review: Patch for phypot - Pygmy Hippotause  ("Kevin Grittner" <Kevin.Grittner@wicourts.gov>)
List pgsql-hackers
It looks good to me: (0) new patch applies cleanly to CVS HEAD; (1)
the formating of the code was changed; (2) definition of the HYPOT
macro was changed to use phypot rather than being removed; (3) the
phypot function was declared to be extern; (4) the comments to the
phypot function were changed to remove the reference about the SUS
behavior.

I changed the status to "Ready for Committer".

Thanks
Andrew

On Fri, Jul 23, 2010 at 4:01 PM, Kevin Grittner
<Kevin.Grittner@wicourts.gov> wrote:
> Tom Lane <tgl@sss.pgh.pa.us> wrote:
>
>> I think the patch is good in principle
>
> Since everyone seems to agree this is a good patch which needed
> minor tweaks, and we haven't heard from the author, I just went
> ahead and made the changes.
>
> Andrew, could you take another look and see if you agree I've
> covered it all before it gets marked ready for a committer?
>
> -Kevin
>


pgsql-hackers by date:

Previous
From: Guillaume Lelarge
Date:
Subject: Re: antisocial things you can do in git (but not CVS)
Next
From: Yeb Havinga
Date:
Subject: Re: Review of Synchronous Replication patches