Re: Windows locales and tests portability - Mailing list pgsql-hackers

From Andrey Borodin
Subject Re: Windows locales and tests portability
Date
Msg-id A733EF40-6E1A-4670-BF83-5E729434340C@yandex-team.ru
Whole thread
In response to Re: Windows locales and tests portability  (Andrew Bille <andrewbille@gmail.com>)
Responses Re: Windows locales and tests portability
List pgsql-hackers
Hi Andrew,

On Sep 22, 2026, Andrew Bille wrote:
> fixing it in frontend locale
> initialization is preferable to teaching individual tests about
> Windows decimal separators.

My patch was intended to adapt the tests to the existing Windows
behavior. Yours changes that behavior for frontend users, which seems
worth discussing separately. A non-empty LC_NUMERIC may already be
inherited by scripts that currently work because Windows ignores it.

There is also the precedence question: this patch applies LC_NUMERIC
without checking LC_ALL, so it does not quite reproduce POSIX behavior.
I'd propose to fix the tests independently while discussing what locale
environment handling we want on Windows.

Thank you!


Best regards, Andrew Borodin.



pgsql-hackers by date:

Previous
From: Andrew Bille
Date:
Subject: Re: Windows locales and tests portability
Next
From: Andrew Bille
Date:
Subject: Re: Windows locales and tests portability