Re: Add sanity check for duplicate enum values in GUC definitions - Mailing list pgsql-hackers

From Chao Li
Subject Re: Add sanity check for duplicate enum values in GUC definitions
Date
Msg-id A68F4A0E-1634-469B-8132-60F1AC14D72A@gmail.com
Whole thread Raw
In response to Re: Add sanity check for duplicate enum values in GUC definitions  (Peter Eisentraut <peter@eisentraut.org>)
Responses Re: Add sanity check for duplicate enum values in GUC definitions
List pgsql-hackers

> On Dec 17, 2025, at 22:51, Peter Eisentraut <peter@eisentraut.org> wrote:
>
> On 15.12.25 10:16, Chao Li wrote:
>> The motivation for this patch comes from my own experience. While working on [1]. I added an enum-typed GUC and made
acopy-and-paste mistake, assigning the same numeric value to two different enum entries. This resulted in confusing
runtimebehavior and cost me about an hour to track down. 
>
> Why do you assign explicit values at all?

Hi Peter,

Did you mean to say “duplicate” instead of “explicit”?

Duplicate values assigning to different enum items was a copy-paste mistake I made during development, which wasted my
timeon debugging the issue. So I wanted to add this sanity check to quickly report such mistake in the first place. 

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/







pgsql-hackers by date:

Previous
From: Andres Freund
Date:
Subject: Re: [PATCH] Expose checkpoint reason to completion log messages.
Next
From: Andres Freund
Date:
Subject: Re: [WIP]Vertical Clustered Index (columnar store extension) - take2