Postgres Pro
Downloads
Home   >   mailing lists

Re: [pgAdmin4][Patch]: RM1569 - Right-clicking an disconnected EPAS server shows "Create Resource Group" option - Mailing list pgadmin-hackers

From Dave Page
Subject Re: [pgAdmin4][Patch]: RM1569 - Right-clicking an disconnected EPAS server shows "Create Resource Group" option
Date
Msg-id A5A0634A-601F-47E5-9834-0572EEDAE922@pgadmin.org
Whole thread Raw
In response to [pgAdmin4][Patch]: RM1569 - Right-clicking an disconnected EPAS server shows "Create Resource Group" option  (Surinder Kumar <surinder.kumar@enterprisedb.com>)
Responses Re: [pgAdmin4][Patch]: RM1569 - Right-clicking an disconnected EPAS server shows "Create Resource Group" option  (Surinder Kumar <surinder.kumar@enterprisedb.com>)
List pgadmin-hackers
Tree view
Hi

That's not a reliable check - you can just as easily use postgres as the maintenance db on epas.

Why don't we just hide the option if disconnected, and if connected, then check the server type?

-- 
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK:http://www.enterprisedb.com
The Enterprise PostgreSQL Company

On 19 Aug 2016, at 19:00, Surinder Kumar <surinder.kumar@enterprisedb.com> wrote:

Hi

Issue:
Two reasons:
1) In Resource group menu, the check for server connected or not is missing.
2) When server is disconnected, server type is always set to 'pg' which is wrong and thus function always returns true.

Solution:
If server is disconnected, we should check server type based on its maintenance db.
If maintenance db is 'edb' its ppas server, otherwise 'pg'.

Please review attached patch.

Thanks,
Surinder Kumar
<RM1569.patch>

--
Sent via pgadmin-hackers mailing list (pgadmin-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

pgadmin-hackers by date:

Previous
From: Surinder Kumar
Date:
Subject: [pgAdmin4][Patch]: RM1251 - Tab complete for combo boxes
Next
From: Surinder Kumar
Date:
Subject: Re: [pgAdmin4][Patch]: RM1569 - Right-clicking an disconnected EPAS server shows "Create Resource Group" option