Re: SSI: ON CONFLICT DO SELECT takes no predicate lock on the returned row - Mailing list pgsql-hackers

Hi Dean,

On 23 Sep 2026, Dean Rasheed wrote:
> Grepping on PGXN, I see no use of ExecCheckIndexConstraints(), so it's
> probably your fix is OK.

I found a caller in pg_lake [0] that creates its own EState without
setting es_snapshot. It pushes an active snapshot, but passes the
unchanged EState to ExecCheckIndexConstraints(). Your proposed
InvalidSnapshot guard would cover this too.

Thank you!


Best regards, Andrey Borodin.

[0]
https://github.com/Snowflake-Labs/pg_lake/blob/44befc068dda9346bca2b0982929d99508d43fdf/pg_lake_table/src/fdw/update_tracking.c#L105-L284