Tab complete for alter table rls - Mailing list pgsql-hackers

From Li Japin
Subject Tab complete for alter table rls
Date
Msg-id A2E0B506-5C05-4A73-B8DD-0ACBC53A1666@hotmail.com
Whole thread Raw
In response to  (Li Japin <japinli@hotmail.com>)
Responses Re: Tab complete for alter table rls
List pgsql-hackers
Sorry, I forgot add the subject.

--
Best regards
Japin Li

On Oct 23, 2020, at 1:19 PM, Li Japin <japinli@hotmail.com> wrote:

Hi, hackers

I find that ALTER TABLE xxx FORCE/NO FORCE ROW LEVEL SECURITY cannot support tab complete.
The attached add the tab complete for rls.

diff --git a/src/bin/psql/tab-complete.c b/src/bin/psql/tab-complete.c
index 561fe1dff9..b2b4f1fd4d 100644
--- a/src/bin/psql/tab-complete.c
+++ b/src/bin/psql/tab-complete.c
@@ -1974,10 +1974,10 @@ psql_completion(const char *text, int start, int end)
  */
  else if (Matches("ALTER", "TABLE", MatchAny))
  COMPLETE_WITH("ADD", "ALTER", "CLUSTER ON", "DISABLE", "DROP",
-  "ENABLE", "INHERIT", "NO INHERIT", "RENAME", "RESET",
+  "ENABLE", "INHERIT", "NO", "RENAME", "RESET",
   "OWNER TO", "SET", "VALIDATE CONSTRAINT",
   "REPLICA IDENTITY", "ATTACH PARTITION",
-  "DETACH PARTITION");
+  "DETACH PARTITION", "FORCE ROW LEVEL SECURITY");
  /* ALTER TABLE xxx ENABLE */
  else if (Matches("ALTER", "TABLE", MatchAny, "ENABLE"))
  COMPLETE_WITH("ALWAYS", "REPLICA", "ROW LEVEL SECURITY", "RULE",
@@ -2007,6 +2007,9 @@ psql_completion(const char *text, int start, int end)
  /* ALTER TABLE xxx INHERIT */
  else if (Matches("ALTER", "TABLE", MatchAny, "INHERIT"))
  COMPLETE_WITH_SCHEMA_QUERY(Query_for_list_of_tables, "");
+ /* ALTER TABLE xxx NO */
+ else if (Matches("ALTER", "TABLE", MatchAny, "NO"))
+ COMPLETE_WITH("FORCE ROW LEVEL SECURITY", "INHERIT");
  /* ALTER TABLE xxx NO INHERIT */
  else if (Matches("ALTER", "TABLE", MatchAny, "NO", "INHERIT"))
  COMPLETE_WITH_SCHEMA_QUERY(Query_for_list_of_tables, "”);

Best regards.


--
ChengDu WenWu Information Technology Co,Ltd.
Japin Li

<0001-Add-tab-complete-for-alter-table-rls.patch>

pgsql-hackers by date:

Previous
From: Li Japin
Date:
Subject:
Next
From: Kyotaro Horiguchi
Date:
Subject: Re: Mop-up around psql's \connect behavior