Postgres Pro
Downloads
Home   >   mailing lists

Re: Refactor ssl tests to avoid using internal PostgreSQL::Test::Cluster methods - Mailing list pgsql-hackers

From Daniel Gustafsson
Subject Re: Refactor ssl tests to avoid using internal PostgreSQL::Test::Cluster methods
Date
Msg-id A23DA57B-CB09-4928-97A5-3B3C9F9F39FF@yesql.se
Whole thread Raw
In response to Re: Refactor ssl tests to avoid using internal PostgreSQL::Test::Cluster methods  (Heikki Linnakangas <hlinnaka@iki.fi>)
List pgsql-hackers
Tree view 
> On 3 Jul 2023, at 13:37, Heikki Linnakangas <hlinnaka@iki.fi> wrote:

> If "pg_ctl restart" fails because of a timeout, for example, the PID file could be present. Previously, the
_update_pid(0)would error out on that, but now it's accepted. I think that's fine, but just wanted to point it out. 

Revisiting an old patch.  Agreed, I think that's fine, so I went ahead and
pushed this.  Thanks for review!

It's unfortunately not that common for buildfarm animals to run the SSL tests,
so I guess I'll keep an extra eye on the CFBot for this one.

--
Daniel Gustafsson

pgsql-hackers by date:

Previous
From: shveta malik
Date:
Subject: Re: Synchronizing slots from primary to standby
Next
From: "Hayato Kuroda (Fujitsu)"
Date:
Subject: RE: pg_ctl start may return 0 even if the postmaster has been already started on Windows