Hi,
Tomas, thanks for review and comments!
> I have to admit I find the existing code a bit convoluted, particularly the part that deals with the (commId ==
negId)case. And the patch does not really improve the situation, quite the contrary.
>
> Perhaps it’s time to get rid of this optimization?
Indeed, code in OperatorUpd is not very easy to read, due to handling this case.
However we can achieve the same results without too much duplication. I have
changed OperatorUpd to perform tuple modification in "lazy" way. Please, check
it out in v4.patch (attached).
> Also, maybe I'm missing something obvious, but it's not immediately obvious to me why we're only checking oprcom and
notoprnegate? I.e. why shouldn’t the code be
We do not need to check for operOid != op->oprnegate, since we can't create
operator that is negator to itself. Thus, opnergate either present and differs
from operator being deleted, or is InvalidOid. I have added some clarification
in the comment for future readers.
Fixed style issues as well.
Cheers,
Roma
