Re: Stabilize and shorten test_checksums/013_rewind test - Mailing list pgsql-hackers

From Daniel Gustafsson
Subject Re: Stabilize and shorten test_checksums/013_rewind test
Date
Msg-id A0DEFB5D-718B-4486-9D15-E9BC2AB35EF9@yesql.se
Whole thread
In response to Re: Stabilize and shorten test_checksums/013_rewind test  (Nazir Bilal Yavuz <byavuz81@gmail.com>)
Responses Re: Stabilize and shorten test_checksums/013_rewind test
List pgsql-hackers
> On 23 Sep 2026, at 12:15, Nazir Bilal Yavuz <byavuz81@gmail.com> wrote:
> On Tue, 22 Sept 2026 at 00:38, Zsolt Parragi <zsolt.parragi@percona.com> wrote:

>> Shouldn't 021 get the same fix (0001)? That's only executed with
>> checksum_extended so its not that visible on CI, but it has the same
>> issue.
>
> Yes, you are right. I realized that we can do the same thing for all
> test_checksum tests, so I applied similar change to all of the related
> checksum tests in 0001.

I've been looking at this patch and have tested it extensively both on local
hardware and CI instances.  Copilot review pointed out one thing which I think
is accurate (though unlikely to happen), if the START WAL LOCATION and
CHECKPOINT LOCATION straddle segments then the test would fail.  Extracting the
WAL filename from $shutdown_ckpt is the safer option.  That fix and some commit
message tweaking are the only changes in the attached v4.

--
Daniel Gustafsson


Attachment

pgsql-hackers by date:

Previous
From: Peter Smith
Date:
Subject: Re: [PATCH] Table sync race with REFRESH PUBLICATION
Next
From: Vlad Lesin
Date:
Subject: ReplicationSlotRelease() clobbers another backend's statusFlags entry