Re: fixing CREATEROLE - Mailing list pgsql-hackers

From Mark Dilger
Subject Re: fixing CREATEROLE
Date
Msg-id A08B35B5-2132-4CDE-93FD-421AA8A690AC@enterprisedb.com
Whole thread Raw
In response to fixing CREATEROLE  (Robert Haas <robertmhaas@gmail.com>)
Responses Re: fixing CREATEROLE
List pgsql-hackers

> On Nov 21, 2022, at 12:39 PM, Robert Haas <robertmhaas@gmail.com> wrote:
>
> I have drafted a few patches to try to improve the situation.

The 0001 and 0002 patches appear to be uncontroversial refactorings.  Patch 0003 looks on-point and a move in the right
direction. The commit message in that patch is well written.  Patch 0004 feels like something that won't get committed.
The INHERITCREATEDROLES and SETCREATEDROLES in 0004 seems clunky. 


—
Mark Dilger
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company






pgsql-hackers by date:

Previous
From: Regina Obe
Date:
Subject: Re: [PATCH] Support % wildcard in extension upgrade filenames
Next
From: Stavros Koureas
Date:
Subject: Re: Logical Replication Custom Column Expression