Re: APC/socket fix (final?) - Mailing list pgsql-patches

From Claudio Natoli
Subject Re: APC/socket fix (final?)
Date
Msg-id A02DEC4D1073D611BAE8525405FCCE2B55F3C8@harris.memetrics.local
Whole thread Raw
In response to APC/socket fix (final?)  (Claudio Natoli <claudio.natoli@memetrics.com>)
List pgsql-patches
Tom Lane wrote:
> Claudio Natoli <claudio.natoli@memetrics.com> writes:
> > ... However, it just occured to me that
> > we could wrap select() by augmenting the read_mask with an
> addition socket,
> > that we know will never be touched, and checking this
> socket on a "valid"
> > return. If this socket is still set, we know we got bitten
> by the APC/socket
> > interaction bug, and can set errno accordingly.
>
> What happens if the socket() call fails?

Then we return in error. Refer to attachment.


> Even if it succeeds, I don't know what the semantics are of selecting on
an un-bound socket ... it
> might perhaps show as error state, for instance.

select doesn't need a socket to be bound to select on it, afaik. In any
case, it isn't necessary under win32, which is what we are discussing.

Cheers,
Claudio

---
Certain disclaimers and policies apply to all email sent from Memetrics.
For the full text of these disclaimers and policies see
<a
href="http://www.memetrics.com/emailpolicy.html">http://www.memetrics.com/em
ailpolicy.html</a>

pgsql-patches by date:

Previous
From: Claudio Natoli
Date:
Subject: Re: APC/socket fix (final?)
Next
From: Tom Lane
Date:
Subject: Re: APC/socket fix (final?)